Skip to content

feat(synthetics): add enum value for Synthetics Canary NodeJS 3.1 runtime#37282

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
bilalq:canary-3-1
Mar 19, 2026
Merged

feat(synthetics): add enum value for Synthetics Canary NodeJS 3.1 runtime#37282
mergify[bot] merged 3 commits intoaws:mainfrom
bilalq:canary-3-1

Conversation

@bilalq
Copy link
Copy Markdown
Contributor

@bilalq bilalq commented Mar 18, 2026

Issue # (if applicable)

N/A

Reason for this change

This was previously missing from the runtime enum. The older version doesn't have types available on npm, so it's difficult and awkward to use.

Description of changes

This change just adds an enum value for the newer version of the runtime. See docs at:
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_Nodejs.html#CloudWatch_Synthetics_runtimeversion-syn-nodejs-3.1

Describe any new or updated permissions being added

N/A

Description of how you validated changes

The documentation was reviewed and the code was checked to be consistent with pre-existing enum values.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Copilot AI review requested due to automatic review settings March 18, 2026 19:58
@github-actions github-actions bot added the p2 label Mar 18, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 18, 2026 19:59
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 18, 2026
@bilalq bilalq changed the title Add enum value for Synthetics Canary NodeJS 3.1 runtime feat(synthetics): Add enum value for Synthetics Canary NodeJS 3.1 runtime Mar 18, 2026
@bilalq bilalq changed the title feat(synthetics): Add enum value for Synthetics Canary NodeJS 3.1 runtime feat(synthetics): add enum value for Synthetics Canary NodeJS 3.1 runtime Mar 18, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the CloudWatch Synthetics syn-nodejs-3.1 canary runtime by exposing it as a Runtime constant in aws-synthetics, making it easier for CDK consumers to select the newer Node.js runtime.

Changes:

  • Add Runtime.SYNTHETICS_NODEJS_3_1 mapped to syn-nodejs-3.1.
  • Document the runtime’s Node.js version and notable features with an AWS docs reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

This was previously missing from the runtime enum.
@bilalq
Copy link
Copy Markdown
Contributor Author

bilalq commented Mar 18, 2026

Exemption Request:

This PR only adds a new enum value. The autogenerated documentation should be sufficient. The last PR that added a new enum value here also had no readme or test changes. See: #36652

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 18, 2026
@alvazjor alvazjor self-assigned this Mar 19, 2026
@alvazjor alvazjor added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 19, 2026
@alvazjor alvazjor removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 19, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 19, 2026 09:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 19, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 19, 2026

Merge Queue Status

  • Entered queue2026-03-19 10:38 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-03-19 11:19 UTC · at 2e3024ede71550b9ba7b0f544964c66723b58a4e

This pull request spent 40 minutes 22 seconds in the queue, including 40 minutes 10 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 19, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit af1e89c into aws:main Mar 19, 2026
18 of 19 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants