fix(spec2cdk): throw on unrecognized uppercase prefix in event pattern#37283
fix(spec2cdk): throw on unrecognized uppercase prefix in event pattern#37283mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 4 seconds in the queue, with no time running CI. ReasonThe pull request can't be updated
HintYou should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Merge Queue Status
This pull request spent 4 seconds in the queue, with no time running CI. ReasonThe pull request can't be updated
HintYou should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 30 minutes 53 seconds in the queue, including 30 minutes 40 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Previously, the function only logged a warning when encountering an event name that starts with an unknown uppercase prefix (e.g., a new service acronym). This made the issue easy to overlook and allowed inconsistent or incorrect pattern method names to be generated silently.
By throwing an error instead of logging, we enforce strict handling of event naming conventions. This ensures that any newly introduced event with a service/acronym prefix is explicitly reviewed and added to the prefixes list, preventing incorrect method name(e.g.,
kMSCMKDeletionPatterninstead ofkmsCMKDeletionPattern) generation and improving long-term maintainability.Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license