Skip to content

feat(core): add source tracing for L1 construct property mutations#37285

Merged
mergify[bot] merged 8 commits intomainfrom
otaviom/capture-property-trace
Mar 23, 2026
Merged

feat(core): add source tracing for L1 construct property mutations#37285
mergify[bot] merged 8 commits intomainfrom
otaviom/capture-property-trace

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

Add traceProperty utility that records metadata with stack traces on CfnResource property setters when CDK_DEBUG=1 is enabled.

Update spec2cdk code generation to emit getter/setter pairs (instead of plain fields) for mutable L1 properties, calling traceProperty in each setter to capture the call site.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add `traceProperty` utility that records metadata with stack traces
on CfnResource property setters when CDK_DEBUG=1 is enabled.

Update spec2cdk code generation to emit getter/setter pairs (instead
of plain fields) for mutable L1 properties, calling `traceProperty`
in each setter to capture the call site.
@otaviomacedo otaviomacedo requested a review from a team as a code owner March 19, 2026 09:13
@github-actions github-actions bot added the p2 label Mar 19, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2026 09:13
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 19, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@otaviomacedo otaviomacedo added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 19, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 19, 2026 13:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 19, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 23, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f0b6da8 into main Mar 23, 2026
21 of 22 checks passed
@mergify mergify bot deleted the otaviom/capture-property-trace branch March 23, 2026 10:28
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 23, 2026

Merge Queue Status

  • Entered queue2026-03-23 10:27 UTC · Rule: default-squash
  • Checks skipped · PR is already up-to-date
  • Merged2026-03-23 10:28 UTC · at 3a45349c8ecb995ea0c23f212adbece0700e753e

This pull request spent 5 seconds in the queue, with no time running CI.

Required conditions to merge

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants