fix(rds): enablePerformanceInsights false is ignored when other performance insight properties are set#37287
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Mar 20, 2026
Conversation
…baseInstanceFromSnapshot The `||` operator in the performance insights enablement logic treated `false` as falsy, causing it to be overridden when other PI-related properties (e.g. `performanceInsightRetention`) were also set. Replace `||` with `??` so that an explicit `false` is respected, while still auto-enabling PI when only related properties are provided. Closes aws#37051
github-actions
bot
added
the
distinguished-contributor
aws-cdk-automation
previously requested changes
Mar 19, 2026
Contributor
Author
|
Exemption Request: This is a logic-only fix in property computation, fully covered by unit tests. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
leonmk-aws
added
the
pr-linter/exempt-integ-test
leonmk-aws
approved these changes
Mar 20, 2026
Contributor
leonmk-aws
left a comment
leonmk-aws
left a comment
There was a problem hiding this comment.
Thank you for your contribution !
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 44 minutes 4 seconds in the queue, including 43 minutes 55 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #37051
Reason for this change
DatabaseInstanceFromSnapshot(and otherDatabaseInstanceNewsubclasses) ignores an explicitenablePerformanceInsights: falsewhen other Performance Insights properties are also set.Description of changes
Replace
||with??in the PI enablement logic so that an explicitfalseis not overridden. Remove the redundant fallback on the CFn property assignment.Description of how you validated changes
Added a unit test for
DatabaseInstanceFromSnapshotwithenablePerformanceInsights: false. All existing tests pass.Checklist