fix(s3): avoid access denied when disabling autoDeleteObjects property#37303
Open
Adityakk9031 wants to merge 3 commits intoaws:mainfrom
Open
fix(s3): avoid access denied when disabling autoDeleteObjects property#37303Adityakk9031 wants to merge 3 commits intoaws:mainfrom
Adityakk9031 wants to merge 3 commits intoaws:mainfrom
Conversation
Disabling autoDeleteObjects removes the bucket policy before the custom resource deletes the bucket, removing the s3:GetBucketTagging permission and causing an AccessDenied error. This includes two fixes: 1. The Lambda explicitly catches AccessDenied when checking tags, assuming the bucket is untagged. 2. The custom resource explicitly adds s3:GetBucketTagging to the Lambda execution IAM role.
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
requested changes
Mar 22, 2026
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Adityakk9031
changed the title
aws-cdk-automation
added
the
pr/needs-further-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #37257
What this PR does / why we need it: When autoDeleteObjects is changed from true to false on an existing bucket, CloudFormation removes the custom Bucket Policy before it fires the Custom Resource deletion event. This causes the Lambda to fail with an AccessDenied error when it attempts to call s3:GetBucketTagging, since its execution role lacks that permission.
This PR fixes the race condition in two complementary ways as suggested in the issue:
Defensive handler fix: Updates
isBucketTaggedForDeletion()
to catch AccessDenied and safely return false, which skips the empty-bucket operation since the policy (and tag) are already confirmed gone.
Architecture fix: Explicitly grants s3:GetBucketTagging directly to the Custom Resource Lambda execution IAM role so it isn't solely dependent on the bucket policy for this call.