fix(events): validate against empty arrays in EventPattern at synth time#37306
Closed
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Closed
fix(events): validate against empty arrays in EventPattern at synth time#37306syukawa-gh wants to merge 2 commits intoaws:mainfrom
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Conversation
EventBridge rejects empty arrays in event patterns, but CDK previously allowed them through synthesis, causing deployment failures. Now renderEventPattern() throws a validation error when any EventPattern field is set to an empty array, catching the issue at synth time. Token-based values are skipped since they cannot be validated at synth. Closes aws#36904
aws-cdk-automation
previously requested changes
Mar 23, 2026
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Collaborator
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Collaborator
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Contributor
Author
|
Closing in favor of #37457 (same change, updated version) |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventBridge rejects empty arrays in event patterns, but CDK previously allowed them through synthesis, causing deployment failures with:
Now
renderEventPattern()throws a validation error when anyEventPatternfield is set to an empty array, catching the issue at synth time instead of deploy time. Token-based values are skipped since they cannot be validated at synth.Closes #36904