fix(kms): Alias.fromAliasName does not prefix alias name with alias/#37308
Closed
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Closed
fix(kms): Alias.fromAliasName does not prefix alias name with alias/#37308syukawa-gh wants to merge 2 commits intoaws:mainfrom
Alias.fromAliasName does not prefix alias name with alias/#37308syukawa-gh wants to merge 2 commits intoaws:mainfrom
Conversation
When using Alias.fromAliasName, the alias name was not automatically prefixed with 'alias/' if not already provided, unlike the Alias constructor which does add the prefix. This caused inconsistent behavior between creating and importing aliases. Now fromAliasName normalizes the alias name by adding the 'alias/' prefix when it is missing (and the value is not an unresolved token). Closes aws#36693
github-actions
bot
added
beginning-contributor
aws-cdk-automation
previously requested changes
Mar 23, 2026
syukawa-gh
changed the title
Alias.fromAliasName does not prefix alias name with alias/
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-further-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
Collaborator
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Collaborator
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Contributor
Author
|
Closing in favor of #37459 (same change, updated version) |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Alias.fromAliasName, the alias name was not automatically prefixed with 'alias/' if not already provided, unlike the Alias constructor. Now fromAliasName normalizes the alias name by adding the 'alias/' prefix when missing (and the value is not an unresolved token).
Closes #36693