fix(s3-deployment): custom logGroup of BucketDeployment is prevented from deletion#37309
Closed
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Closed
fix(s3-deployment): custom logGroup of BucketDeployment is prevented from deletion#37309syukawa-gh wants to merge 2 commits intoaws:mainfrom
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Conversation
When a custom logGroup is passed to BucketDeployment, the log group could be deleted before the Lambda handler during stack deletion. If the Lambda runs after the log group is deleted, it recreates the log group, preventing proper cleanup. Add a dependency from the handler to the logGroup so that CloudFormation deletes the log group only after the Lambda handler is deleted. Closes aws#35632
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Mar 23, 2026
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
Author
|
Superseded by new PR - the original accidentally overwrote an existing integ test file. |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom
logGroupis passed toBucketDeployment, the log group could be deleted before the Lambda handler during stack deletion. If the Lambda runs after the log group is deleted, it recreates the log group, preventing proper cleanup.This adds a dependency from the handler to the
logGroupso that CloudFormation deletes the log group only after the Lambda handler is deleted.Closes #35632