Skip to content

feat(elbv2): allow logAccessLogs on environment-agnostic stacks#37319

Open
syukawa-gh wants to merge 3 commits intoaws:mainfrom
syukawa-gh:feat/elbv2-log-access-logs-agnostic-clean
Open

feat(elbv2): allow logAccessLogs on environment-agnostic stacks#37319
syukawa-gh wants to merge 3 commits intoaws:mainfrom
syukawa-gh:feat/elbv2-log-access-logs-agnostic-clean

Conversation

@syukawa-gh
Copy link
Copy Markdown
Contributor

Previously, calling logAccessLogs on a load balancer in an environment-agnostic stack (no region specified) threw an error. Now it falls back to the logdelivery.elasticloadbalancing.amazonaws.com service principal, which works in all regions.

This is consistent with the existing behavior when the region doesn't map to a known ELBv2 account (new regions).

Closes #27432

Previously, calling logAccessLogs on a load balancer in an
environment-agnostic stack (no region specified) threw an error.
Now it falls back to the logdelivery.elasticloadbalancing.amazonaws.com
service principal, which works in all regions.

Closes aws#27432
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 23, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 23, 2026 03:49
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@syukawa-gh
Copy link
Copy Markdown
Contributor Author

Exemption Request: Integration test snapshot cannot be generated locally because the behavior change (using service principal for env-agnostic stacks) is not yet in the released aws-cdk-lib. Unit test and README have been added.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 23, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 24, 2026 01:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elasticloadbalancing: allow logAccessLogs on environment agnostic stack

3 participants