fix(amplify): custom domain with blank prefix causes stack drift#37325
fix(amplify): custom domain with blank prefix causes stack drift#37325syukawa-gh wants to merge 2 commits intoaws:mainfrom
Conversation
When a subdomain is mapped with an empty string prefix, the CloudFormation template includes 'Prefix: ""' but AWS omits empty prefix values, causing immediate stack drift. Now omit the prefix property entirely when it is an empty string. Closes aws#35958
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: This PR fixes a stack drift issue by omitting empty prefix from CloudFormation template. Unit test has been added. Integration test would require an actual Amplify app with a custom domain, which is not practical for automated testing. |
|
Closing this PR. After further investigation, the |
|
Comments on closed issues and PRs are hard for our team to see. |
When a subdomain is mapped with an empty string prefix, the CloudFormation template includes
Prefix: ""but AWS omits empty prefix values, causing immediate stack drift after deployment.Now omit the
prefixproperty entirely when it is an empty string.Closes #35958