fix(certificatemanager): apexDomain returns incorrect results for domains colliding with Object.prototype#37329
Closed
syukawa-gh wants to merge 3 commits intoaws:mainfrom
Closed
Conversation
…omains colliding with Object.prototype The apexDomain utility used the `in` operator which checks the entire prototype chain. Domains containing segments like 'toString' or 'valueOf' would incorrectly match Object.prototype properties. Replaced with Object.hasOwn() to only check own properties. Closes aws#37193
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Mar 23, 2026
Contributor
Author
|
Exemption Request: This PR fixes a logic bug in a utility function. Unit test has been added. Integration test is not applicable as |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-further-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
Contributor
Author
|
Closing in favor of #37477 (same change, updated version) |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
apexDomainutility used theinoperator which checks the entire prototype chain. Domains containing segments liketoStringorvalueOfwould incorrectly matchObject.prototypeproperties, resulting in an incorrect apex domain.Replaced with
Object.hasOwn()to only check own properties of thepublicSuffixesobject.Closes #37193