feat(mixins-preview): generate metrics facades#37334
feat(mixins-preview): generate metrics facades#37334leonmk-aws wants to merge 15 commits intomainfrom
Conversation
|
|
||||||||||||||
|
|
||||||||||||||
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
left a comment
There was a problem hiding this comment.
Can you move the codegen directly into spec2cdk and just have the most minimal wrapper code in mixins-preview. I think it was a mistake to have it not in the shared package. See the cfn prop mixins on how this can be done generating into any destination.
Also, should we have a separate preview/alpha package? Feels like we have now decided that mixins-preview should be removed soon.
3e1e994 to
fdd8bea
Compare
Description of changes
Automatically generate metrics facades.
Usage:
Generated code structure:
Description of how you validated changes
Added unit and integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license