Skip to content

fix(applicationsignals-alpha): do not set user for Windows containers in CloudWatchAgentIntegration#37346

Open
syukawa-gh wants to merge 1 commit intoaws:mainfrom
syukawa-gh:fix/applicationsignals-windows-user
Open

fix(applicationsignals-alpha): do not set user for Windows containers in CloudWatchAgentIntegration#37346
syukawa-gh wants to merge 1 commit intoaws:mainfrom
syukawa-gh:fix/applicationsignals-windows-user

Conversation

@syukawa-gh
Copy link
Copy Markdown
Contributor

The user: '0:1338' property was unconditionally set for all containers, including Windows. The User parameter is not supported on Windows containers and causes a CannotStartContainerError (0x52e — "The user name or password is incorrect").

This change skips setting user when the operating system family is Windows.

Changes

  • ecs-cloudwatch-agent.ts: Conditionally set user only for non-Windows OS families
  • ecs-cloudwatch-agent.test.ts: Updated Windows sidecar test to not expect User property

Closes #34560

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Mar 24, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 24, 2026 07:42
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

…rs in `CloudWatchAgentIntegration`

The `user: '0:1338'` property was unconditionally set for all containers,
including Windows. The `User` parameter is not supported on Windows
containers and causes a CannotStartContainerError (0x52e).

Skip setting `user` when the operating system family is Windows.

Closes aws#34560
@syukawa-gh syukawa-gh force-pushed the fix/applicationsignals-windows-user branch from a36ec6c to 999b541 Compare March 24, 2026 07:50
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 24, 2026 07:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(applicationsignals-alpha): deployment fails on windows hosts with user/password error

3 participants