fix(elbv2): dropInvalidHeaderFields not reflected in CloudFormation when set to false#37373
fix(elbv2): dropInvalidHeaderFields not reflected in CloudFormation when set to false#37373syukawa-gh wants to merge 1 commit intoaws:mainfrom
dropInvalidHeaderFields not reflected in CloudFormation when set to false#37373Conversation
When `dropInvalidHeaderFields` is explicitly set to `false`, the attribute was omitted from the CloudFormation template because the condition `if (props.dropInvalidHeaderFields)` evaluates to false. Change the check to `!== undefined` so that both `true` and `false` values are included in the template. Closes aws#36409
github-actions
bot
added
beginning-contributor
|
Exemption Request: This PR fixes a one-line condition check and adds a unit test. Integration test is not applicable as this is a load balancer attribute change that doesn't affect CloudFormation resource structure. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
|
Closing in favor of #37460 (same change, updated version) |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
Reason for this change
When
dropInvalidHeaderFieldsis explicitly set tofalse, the attribute is omitted from the CloudFormation template. This prevents rolling back the setting fromtruetofalse.Closes #36409
Description of changes
Change
if (props.dropInvalidHeaderFields)toif (props.dropInvalidHeaderFields !== undefined)so that bothtrueandfalsevalues are included in the template, matching the pattern used byhttp2Enabled.Description of how you validated changes
Added a unit test that verifies the attribute is present in the template when set to
false.Checklist