chore: remove obsolete tslint disable comments#37398
Closed
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Closed
chore: remove obsolete tslint disable comments#37398syukawa-gh wants to merge 1 commit intoaws:mainfrom
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Conversation
The project migrated from tslint to eslint. Remove leftover tslint disable comments that no longer serve any purpose: - aws-ec2/lib/vpc.ts: tslint:disable-next-line: max-line-length - aws-ecs/lib/cluster.ts: tslint:disable-next-line: max-line-length - aws-ec2-alpha/lib/util.ts: tslint:disable:no-bitwise
github-actions
bot
added
the
beginning-contributor
Contributor
Author
|
Closing as duplicate. These changes are already included in #37358. |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
N/A (self-discovered)
Reason for this change
The project migrated from tslint to eslint. These leftover
tslint:disablecomments no longer serve any purpose.Description of changes
Removed 3 obsolete tslint disable comments:
aws-ec2/lib/vpc.ts:tslint:disable-next-line: max-line-lengthaws-ecs/lib/cluster.ts:tslint:disable-next-line: max-line-lengthaws-ec2-alpha/lib/util.ts:tslint:disable:no-bitwiseDescription of how you validated changes
Comment-only removal. No functional impact.
Checklist