Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-iam/lib/private/imported-role.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class ImportedRole extends Resource implements IRole, IComparablePrincipa

@MethodMetadata()
public addManagedPolicy(policy: IManagedPolicy): void {
// Using "Type Predicate" to confirm x is ManagedPolicy, which allows to avoid
// Using "Type Predicate" to confirm x is ManagedPolicy, which allows us to avoid
// using try ... catch and throw error.
const isManagedPolicy = (x: IManagedPolicy): x is ManagedPolicy => {
return (x as ManagedPolicy).attachToRole !== undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-rds/lib/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export abstract class Credentials {
* @param secret The secret where the credentials are stored
* @param username The username defined in the secret. If specified the username
* will be referenced as a string and not a dynamic reference to the username
* field in the secret. This allows to replace the secret without replacing the
* field in the secret. This allows you to replace the secret without replacing the
* instance or cluster.
*/
public static fromSecret(secret: secretsmanager.ISecret, username?: string): Credentials {
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-route53/lib/record-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export interface RecordSetOptions {
/**
* Whether to delete the same record set in the hosted zone if it already exists (dangerous!)
*
* This allows to deploy a new record set while minimizing the downtime because the
* This allows you to deploy a new record set while minimizing the downtime because the
* new record set will be created immediately after the existing one is deleted. It
* also avoids "manual" actions to delete existing record sets.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-secretsmanager/lib/secret.ts
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ export class SecretTargetAttachment extends SecretBase implements ISecretTargetA
this.encryptionKey = this.attachedSecret.encryptionKey;
this.secretName = this.attachedSecret.secretName;

// This allows to reference the secret after attachment (dependency).
// This allows you to reference the secret after attachment (dependency).
this.secretArn = attachment.ref;
this.secretTargetAttachmentSecretArn = attachment.ref;
}
Expand Down
Loading