Skip to content

fix(eks): downgrade isolated subnet validation from error to warning#37500

Merged
mergify[bot] merged 3 commits intomainfrom
fix/eks-isolated-subnet-warning
Apr 2, 2026
Merged

fix(eks): downgrade isolated subnet validation from error to warning#37500
mergify[bot] merged 3 commits intomainfrom
fix/eks-isolated-subnet-warning

Conversation

@Abogical
Copy link
Copy Markdown
Member

@Abogical Abogical commented Apr 2, 2026

Issue

Closes #37491

Reason for this change

The validation added in v2.246.0 (commit 73e5006) throws a hard error when using PRIVATE_ISOLATED subnets for kubectl, blocking a legitimate AWS-supported pattern for fully private EKS clusters with VPC endpoints.

AWS explicitly documents that private EKS clusters can run in isolated subnets when the appropriate VPC endpoints (STS, EKS, ECR, S3, CloudWatch Logs, etc.) are configured.

Description of changes

  • Changed the ValidationError (hard error) to Annotations.addWarningV2 (warning) in both aws-eks and aws-eks-v2 cluster implementations
  • Updated tests to assert the warning is emitted instead of expecting a throw
  • Warning ID: @aws-cdk/aws-eks:isolatedSubnetsForKubectlPrivateSubnets

Description of how you validated changes

Updated unit tests pass. The existing tests for PRIVATE_WITH_EGRESS subnets and imported VPCs with isolated subnets continue to pass unchanged.

Checklist

The validation added in v2.246.0 throws an error when using
PRIVATE_ISOLATED subnets for kubectl, blocking a legitimate
AWS-supported pattern for fully private EKS clusters with VPC
endpoints.

This changes the validation to emit a warning instead, allowing
users who have properly configured VPC endpoints (STS, EKS, ECR,
S3, etc.) to synth successfully.

Closes #37491
@aws-cdk-automation aws-cdk-automation requested a review from a team April 2, 2026 09:41
@github-actions github-actions bot added bug This issue is a bug. p0 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Apr 2, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 2, 2026
@mergify mergify bot temporarily deployed to automation April 2, 2026 09:42 Inactive
@mergify mergify bot temporarily deployed to automation April 2, 2026 09:42 Inactive
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aemada-aws aemada-aws added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Apr 2, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 2, 2026 10:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2026

Merge Queue Status

  • Entered queue2026-04-02 10:56 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-04-02 11:26 UTC · at c7fb2932123bb5e446d5304b8bdb4f325c4fba42

This pull request spent 30 minutes 11 seconds in the queue, including 29 minutes 59 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 470856c into main Apr 2, 2026
19 of 20 checks passed
@mergify mergify bot deleted the fix/eks-isolated-subnet-warning branch April 2, 2026 11:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p0 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-eks): CDK synth fails when using private isolated subnets with eks cluster and kubectl

3 participants