Skip to content

refactor(mixins-preview): rename standalone event pattern methods to eventPattern#37548

Merged
mergify[bot] merged 2 commits intomainfrom
rename-standalone-events
Apr 9, 2026
Merged

refactor(mixins-preview): rename standalone event pattern methods to eventPattern#37548
mergify[bot] merged 2 commits intomainfrom
rename-standalone-events

Conversation

@gasolima
Copy link
Copy Markdown
Contributor

@gasolima gasolima commented Apr 8, 2026

Issue # (if applicable)

Closes #.

Reason for this change

Standalone event pattern static methods had redundant names(e.g.,AWSAPICallViaCloudTrail.awsAPICallViaCloudTrailPattern()) where the class name was repeated in the method name. Renaming to AWSAPICallViaCloudTrail.eventPattern() makes the API cleaner

Description of changes

  • Renamed all standalone (static) event pattern methods from Pattern() to eventPattern() (e.g., ObjectCreated.objectCreatedPattern()ObjectCreated.eventPattern())
  • Updated tests in test/events/aws-s3/events.test.ts to use the new method names
  • Updated README examples and documentation to reflect the rename

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn run build passes with 0 errors.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 8, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2026 11:24
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 8, 2026
@mergify mergify bot temporarily deployed to automation April 8, 2026 11:25 Inactive
@mergify mergify bot temporarily deployed to automation April 8, 2026 11:25 Inactive
@gasolima gasolima changed the title refactor(mixins-preview): rename standalone event pattern methods to … refactor(mixins-preview): rename standalone event pattern methods to eventPattern Apr 8, 2026
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 9, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 9, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 9, 2026

Merge Queue Status

  • Entered queue2026-04-09 09:21 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-04-09 11:33 UTC · at bfaf1d66fb06fdbdeb39984e25e88ab868d12629

This pull request spent 2 hours 11 minutes 33 seconds in the queue, including 43 minutes 18 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 9, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ba2502e into main Apr 9, 2026
19 of 20 checks passed
@mergify mergify bot deleted the rename-standalone-events branch April 9, 2026 11:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants