Skip to content

chore(framework-integ): replace some deprecated API usage#37552

Merged
mergify[bot] merged 2 commits intomainfrom
otaviom/deprecated-apis-integ-tests-2
Apr 8, 2026
Merged

chore(framework-integ): replace some deprecated API usage#37552
mergify[bot] merged 2 commits intomainfrom
otaviom/deprecated-apis-integ-tests-2

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

More updates to integ tests to get rid of deprecated API usage.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 8, 2026
@mergify mergify bot temporarily deployed to automation April 8, 2026 15:55 Inactive
@mergify mergify bot temporarily deployed to automation April 8, 2026 15:55 Inactive
@github-actions github-actions bot added the p2 label Apr 8, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2026 15:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results528 ran525 passed3 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.nat-instance-credit.js.snapshot/aws-cdk-vpc-nat-instance-credit.template.json
ec2-no-open-security-groups.guard❌ failure
packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.nat-instances.lit.js.snapshot/aws-cdk-vpc-nat-instances.template.json
ec2-no-open-security-groups.guard❌ failure
packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancing/test/integ.instanceTarget.elb.js.snapshot/aws-cdk-elb-instance-target-integ.template.json
ec2-no-open-security-groups.guard❌ failure

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates528 ran525 passed3 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.nat-instance-credit.js.snapshot/aws-cdk-vpc-nat-instance-credit.template.json
ec2-no-open-security-groups.guard❌ failure
packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.nat-instances.lit.js.snapshot/aws-cdk-vpc-nat-instances.template.json
ec2-no-open-security-groups.guard❌ failure
packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancing/test/integ.instanceTarget.elb.js.snapshot/aws-cdk-elb-instance-target-integ.template.json
ec2-no-open-security-groups.guard❌ failure

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 8, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2026

Merge Queue Status

  • Entered queue2026-04-08 16:47 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-04-08 17:16 UTC · at a11b369200d5a841b556284e7a548d8f5970f512

This pull request spent 28 minutes 51 seconds in the queue, including 28 minutes 33 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6e4f891 into main Apr 8, 2026
21 of 25 checks passed
@mergify mergify bot deleted the otaviom/deprecated-apis-integ-tests-2 branch April 8, 2026 17:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants