chore: include cfn-property-mixins in spec-update workflow gen step#37556
Merged
vishaalmehrishi merged 1 commit intomainfrom Apr 9, 2026
Merged
chore: include cfn-property-mixins in spec-update workflow gen step#37556vishaalmehrishi merged 1 commit intomainfrom
vishaalmehrishi merged 1 commit intomainfrom
Conversation
The spec-update workflow was missing @aws-cdk/cfn-property-mixins in its gen step. When new services are added (e.g. NovaAct, SecurityAgent), the cfn-property-mixins gen script updates package.json exports, but since those changes weren't included in the commit, the PR build fails with uncommitted changes detected by git diff-index. This is the same class of issue fixed in #36300 for mixins-preview.
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
previously requested changes
Apr 9, 2026
rix0rrr
approved these changes
Apr 9, 2026
mrgrain
approved these changes
Apr 9, 2026
vishaalmehrishi
changed the title
vishaalmehrishi
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
|
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes the recurring build failure on L1 spec update PRs (e.g. #37530) where
git diff-indexdetects uncommitted changes inpackages/@aws-cdk/cfn-property-mixins/package.json.Reason for this change
When
@aws-cdk/cfn-property-mixinsgraduated frommixins-previewto a standalone package in #37215, it gained its owngenscript that regeneratespackage.jsonexports from the service spec database. However, thespec-update.ymlworkflow was never updated to include it in the gen step.When new CloudFormation services are added (e.g.
AWS::NovaAct,AWS::SecurityAgent), the gen script adds export entries tocfn-property-mixins/package.json. Since these changes aren't included in the automation commit, the PR build fails thegit diff-indexcheck.This is the same class of issue previously fixed in #36300 for
@aws-cdk/mixins-preview.Description of changes
Added
--scope @aws-cdk/cfn-property-mixinsto the gen step in.github/workflows/spec-update.yml, and added a comment explaining why all three scopes are required.Description of how you validated changes
Confirmed the root cause by examining the build logs for PR #37530 which show exactly
cfn-property-mixins/package.jsonwith 2 uncommitted insertions.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license