Conversation
eca5325 to
5db51c6
Compare
5db51c6 to
0d4ef7e
Compare
|
|
valerena
left a comment
There was a problem hiding this comment.
There's a samcli/lib/build/constants.py file, with a list of deprecated runtimes, where we should add python3.8. And the corresponding tests for that are in tests/unit/lib/build_module/test_app_builder.py
There's also a message in pytest.ini that says that an ignore option (ignore::boto3.exceptions.PythonDeprecationWarning) can be removed after we stop supporting python3.7, so we might want to get rid of that too
| { | ||
| "project_name": "Name of the project", | ||
| "runtime": "python3.8", | ||
| "runtime": "python3.9", |
There was a problem hiding this comment.
It would probably be good to update this to a newer version of python right away (python3.13), because this is the default init template if people have problems downloading the full list of templates.
|
This has been waiting for so long that support for Python 3.9 should also be removed |
Remove python 3.8 support
Which issue(s) does this change fix?
Why is this change necessary?
Python 3.8 is deprecated
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.