Skip to content

feat: add ruby3.4 support#7940

Merged
valerena merged 2 commits intoaws:developfrom
valerena:ruby3.4
Mar 27, 2025
Merged

feat: add ruby3.4 support#7940
valerena merged 2 commits intoaws:developfrom
valerena:ruby3.4

Conversation

@valerena
Copy link
Copy Markdown
Contributor

New Lambda managed runtime: Ruby 3.4 (ruby3.4)

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

Also checked the previous PR for Ruby 3.3 support: #6878 (in that case it was added as a "preview" runtime)

Changes related to integration/canary tests (AppVeyor) will come separately (some of them require other tools to be updated too, like build images, app templates or cfn-lint).

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

New Lambda managed runtime: Ruby 3.4 (`ruby3.4`)
@valerena valerena requested a review from a team as a code owner March 18, 2025 22:59
@github-actions github-actions Bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/internal labels Mar 18, 2025
@Vandita2020
Copy link
Copy Markdown
Contributor

I see in the code that we have a couple more tests. Do we want to add Ruby 3.4 to those tests as well? I have linked some of the tests that I think we should include this new version in.

  1. tests/unit/local/docker/test_lambda_image.py
  2. tests/integration/buildcmd/test_build_cmd_arm64.py
  3. tests/integration/validate/test_validate_command.py
  4. tests/integration/testdata/buildcmd/Ruby34

@valerena
Copy link
Copy Markdown
Contributor Author

@Vandita2020

I see in the code that we have a couple more tests. Do we want to add Ruby 3.4 to those tests as well? I have linked some of the tests that I think we should include this new version in.

  1. tests/unit/local/docker/test_lambda_image.py
  2. tests/integration/buildcmd/test_build_cmd_arm64.py
  3. tests/integration/validate/test_validate_command.py
  4. tests/integration/testdata/buildcmd/Ruby34

The first one is a test to try some edge cases in runtime image, and it's not necessarily valuable to add every runtime there (there were some special edge cases for Go and Provided runtimes). The other ones are integration tests that will be added separately. (Maybe I should have sent those already, but they still can't be merged until all the build images and all parts are all merged already)

@valerena valerena enabled auto-merge March 26, 2025 23:05
@valerena valerena added this pull request to the merge queue Mar 27, 2025
Merged via the queue into aws:develop with commit dc615c6 Mar 27, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants