Conversation
tobixlea
approved these changes
Mar 3, 2026
valerena
reviewed
Mar 4, 2026
| run: | | ||
| git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git | ||
| git config user.name "aws-sam-cli-bot" | ||
| git config user.email "aws-sam-cli-gh-bot@amazon.com" |
Contributor
There was a problem hiding this comment.
Is this a real email? (does it have to be a real e-mail?)
Contributor
Author
There was a problem hiding this comment.
it doesn't have to be a real email, it's just the one that gets written in the commit history. This is the bot's real email though, should we not have this?
Contributor
There was a problem hiding this comment.
I guess I'm not sure. I was mostly curious, but it's okay.
valerena
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
update mirror action to use secret in mirror repo instead of git token, since git tokens do not have enough permissions to sync all files, such as workflow files
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.