Skip to content

Allow disabling trailing checksum support. #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flx5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow disabling trailing checksum support. #3314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 42 additions & 17 deletions ...codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpChecksumGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,18 @@ public void processFinalizedModel(GoSettings settings, Model model) {
.build())
.build());

var inputhecksumConfigs = RuntimeClientPlugin.builder()
.servicePredicate(this::supportsTrailingChecksum)
.addConfigField(
ConfigField.builder()
.name("DisableTrailingChecksumSupport")
.type(GoUniverseTypes.Bool)
.documentation("Allow disabling trailing headers for server implementations not supporting this")
.build()
)
.build();
runtimeClientPlugins.add(inputhecksumConfigs);

// Output helper
String outputHelperFuncName = getAddOutputMiddlewareFuncName(
symbolProvider.toSymbol(operation).getName()
Expand Down Expand Up @@ -248,27 +260,12 @@ private void writeInputMiddlewareHelper(
) {
Symbol operationSymbol = symbolProvider.toSymbol(operation);
String operationName = operationSymbol.getName();
StructureShape input = model.expectShape(operation.getInput().get(), StructureShape.class);

HttpChecksumTrait trait = operation.expectTrait(HttpChecksumTrait.class);
boolean isRequestChecksumRequired = trait.isRequestChecksumRequired();
boolean hasRequestAlgorithmMember = trait.getRequestAlgorithmMember().isPresent();

boolean supportsTrailingChecksum = false;
for (MemberShape memberShape : input.getAllMembers().values()) {
Shape targetShape = model.expectShape(memberShape.getTarget());
if (targetShape.hasTrait(StreamingTrait.class) &&
!StreamingTrait.isEventStream(model, memberShape)
) {
if (isS3ServiceShape(model, service) || (
AwsSignatureVersion4.hasSigV4AuthScheme(model, service, operation)
&& !operation.hasTrait(UnsignedPayloadTrait.class))) {
supportsTrailingChecksum = true;
}
}
}

boolean supportsRequestTrailingChecksum = supportsTrailingChecksum;
boolean supportsRequestTrailingChecksum = supportsTrailingChecksum(model, service, operation);
boolean supportsDecodedContentLengthHeader = isS3ServiceShape(model, service);

// imports
Expand All @@ -290,13 +287,41 @@ private void writeInputMiddlewareHelper(
hasRequestAlgorithmMember ?
getRequestAlgorithmAccessorFuncName(operationName) : "nil",
isRequestChecksumRequired,
supportsRequestTrailingChecksum,
supportsRequestTrailingChecksum ? "!options.DisableTrailingChecksumSupport" : "false",
supportsDecodedContentLengthHeader);
}
);
writer.insertTrailingNewline();
}

private boolean supportsTrailingChecksum(Model model, ServiceShape service) {
for (OperationShape operation : TopDownIndex.of(model).getContainedOperations(service)) {
if (supportsTrailingChecksum(model, service, operation)) {
return true;
}
}
return false;
}

private boolean supportsTrailingChecksum(Model model, ServiceShape service, OperationShape operation) {
StructureShape input = model.expectShape(operation.getInput().get(), StructureShape.class);

boolean supportsTrailingChecksum = false;
for (MemberShape memberShape : input.getAllMembers().values()) {
Shape targetShape = model.expectShape(memberShape.getTarget());
if (targetShape.hasTrait(StreamingTrait.class) &&
!StreamingTrait.isEventStream(model, memberShape)
) {
if (isS3ServiceShape(model, service) || (
AwsSignatureVersion4.hasSigV4AuthScheme(model, service, operation)
&& !operation.hasTrait(UnsignedPayloadTrait.class))) {
supportsTrailingChecksum = true;
}
}
}
return supportsTrailingChecksum;
}

// adapted (service/internal/checksum).AddInputMiddleware to give the service client control over its middleware stack,
// per #2507
private void writePackageLevelAddInputChecksumMiddleware(GoWriter writer) {
Expand Down
⚡