Open
Conversation
Collaborator
|
I agree that this was likely a miss when it was first implemented. However, this can have more important consequences, since if an invalid token was received we would have previously ignored the issue and returned a zero-d time and we'd now throw an error on unmarshal. Have you encountered this in your workflow? |
Contributor
Author
|
I haven't run in to this. I go after swallowed errors because of the difficulties they present when trying to debug. If this is too big a change, I can just turn it into a warning and be rid of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a dropped
errvariable incredentials/ssocreds. Unit tests continue to pass after this change.