Add endpoint rules and tests to kitchensink model#3371
Merged
Conversation
lucix-aws
approved these changes
Apr 2, 2026
wty-Bryant
approved these changes
Apr 2, 2026
wty-Bryant
reviewed
Apr 2, 2026
| // The AWS region | ||
| // | ||
| // AWS::Region | ||
| Region *string |
Contributor
There was a problem hiding this comment.
Just to double confirm: all new go runtime in this PR is generated from existing endpoint/protocol generator which ignores new bdd trait right?
Collaborator
Author
There was a problem hiding this comment.
Correct. You made me question it so I did the regen on a new workspace, got the same results :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
endpointRuleSetandendpointTeststo our kitchensink model. This is in preparation to add aendpointBddtrait https://smithy.io/2.0/additional-specs/rules-engine/specification.html#smithy-rules-endpointbdd-traitNOTE: I don't know why on kitchensink model we use full namespace instead of something like
use smithy.rules#endpointTests, but followed the existing convention