chore: add additional text to CONTRIBUTING.md#3372
Merged
wty-Bryant merged 2 commits intoaws:mainfrom Apr 1, 2026
Merged
Conversation
wty-Bryant
reviewed
Mar 31, 2026
Contributor
wty-Bryant
left a comment
wty-Bryant
left a comment
There was a problem hiding this comment.
integ/codegen test failed since this is a PR from fork repo I guess, otherwise LGTM, should we also update contribution section in README?
Member
Author
Yep, configure-aws-credentials typically fails in fork-sourced PRs due to permissions on the GITHUB_TOKEN
Up to you. I think so :) |
wty-Bryant
approved these changes
Mar 31, 2026
Contributor
wty-Bryant
left a comment
wty-Bryant
left a comment
There was a problem hiding this comment.
Will merge after remaining CI tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.