fix(core): make CREDENTIALS_CODE mutually exclusive with other credential sources#7615
Merged
fix(core): make CREDENTIALS_CODE mutually exclusive with other credential sources#7615
Conversation
kuhe
reviewed
Jan 5, 2026
|
|
||
| // Only set CREDENTIALS_CODE if user provided a credential object | ||
| if (isCredentialObject) { | ||
| return setCredentialFeature(attributedCreds, "CREDENTIALS_CODE", "e"); |
Contributor
There was a problem hiding this comment.
I think this still needs to check that no other attribution exists in $source
kuhe
approved these changes
Jan 5, 2026
siddsriv
approved these changes
Jan 5, 2026
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-6433
Description
This fixes double credential attribution where provider credentials (e.g.,
fromEnv()) were incorrectly getting both their specific source attribution andCREDENTIALS_CODE.Testing
yarn test:integrationChecklist
*.integ.spec.ts).@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.