feat(sagemaker): Added the api path to the detached server for supporting reconnection#8767
Open
msgupta-amazon wants to merge 22 commits into
Open
Conversation
Modified the codeowners file to support sagemaker-code-editor team
…rting reconnection
…pta-amazon/aws-toolkit-vscode into reconnection-implementation-storing
…-storing Reconnection implementation storing
…rting reconnection
|
…t-vscode into reconnection-implementation-v2
fb47f37 to
978aedb
Compare
…to reconnection-implementation-v2
d256f5f to
b696fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently we don't support reconnection for parker.
Solution
This PR is the first step to add that functionality.
As part of this PR, we are just adding the route to the detached server for the api.
Testing
This feature will be released as independent components and this PR is for the first component, therefore we have made sure that there are no exiting functionalities breaking and we are able to call the api locally.
Note
Changelog won't be added as it is a component of the feature not the whole feature which is getting released.
Failures in the tests are unrelated to sagemaker service.
feature/xbranches will not be squash-merged at release time.