Skip to content

fix(sagemaker): update metrics for Jorus dashboard#8807

Open
aws-ajangg wants to merge 2 commits into
aws:masterfrom
aws-ajangg:feat/sagemaker-studio-telemetry-account-id
Open

fix(sagemaker): update metrics for Jorus dashboard#8807
aws-ajangg wants to merge 2 commits into
aws:masterfrom
aws-ajangg:feat/sagemaker-studio-telemetry-account-id

Conversation

@aws-ajangg

Copy link
Copy Markdown
Contributor

Problem

The Jorus (SageMaker Studio) telemetry dashboard shows ~75% of events with awsAccount: not-set and awsRegion: not-set. This happens because deeplink and remote connection flows don't have active AWS credentials in the extension context, so the default telemetry injection (injectCommonMetadata) falls through to "not-set". Additionally, HyperPod deeplink events emit sagemaker_deeplinkConnect, polluting the Jorus dashboard with non-Jorus traffic.

Solution

  1. Record awsAccount/awsRegion at each call site where the data is available
  2. Prevent default injection from overwriting explicit values.
  3. Separate HyperPod deeplink into its own metric which will remove false values tracked on Jorus dashboard

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amazon-inspector-ohio

Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions

Copy link
Copy Markdown
  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio

Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

@aws-ajangg aws-ajangg changed the title fix(sagemaker): add AccountId telemetry for Jorus Kibana dashboard fix(sagemaker): update metrics for Jorus dashboard Jun 15, 2026
…eeplink metric

- Record awsAccount/awsRegion on all sagemaker_* telemetry spans
  (openRemoteConnection, stopSpace, filterSpaces, deeplinkConnect)
- Separate HyperPod deeplink into its own hyperpod_deeplinkConnect metric
  so it doesn't pollute Jorus dashboard data
- Skip default awsAccount injection when already set by span.record()
@aws-ajangg aws-ajangg force-pushed the feat/sagemaker-studio-telemetry-account-id branch from 7765b1f to 22ed9eb Compare June 16, 2026 18:21
@aws-ajangg aws-ajangg marked this pull request as ready for review June 16, 2026 18:42
@aws-ajangg aws-ajangg requested a review from a team June 16, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants