fix(sagemaker): update metrics for Jorus dashboard#8807
Open
aws-ajangg wants to merge 2 commits into
Open
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
aws-jeffrey-yang
approved these changes
Jun 16, 2026
…eeplink metric - Record awsAccount/awsRegion on all sagemaker_* telemetry spans (openRemoteConnection, stopSpace, filterSpaces, deeplinkConnect) - Separate HyperPod deeplink into its own hyperpod_deeplinkConnect metric so it doesn't pollute Jorus dashboard data - Skip default awsAccount injection when already set by span.record()
7765b1f to
22ed9eb
Compare
earaghbidikashani
approved these changes
Jun 16, 2026
afida23
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Jorus (SageMaker Studio) telemetry dashboard shows ~75% of events with awsAccount: not-set and awsRegion: not-set. This happens because deeplink and remote connection flows don't have active AWS credentials in the extension context, so the default telemetry injection (injectCommonMetadata) falls through to "not-set". Additionally, HyperPod deeplink events emit sagemaker_deeplinkConnect, polluting the Jorus dashboard with non-Jorus traffic.
Solution
feature/xbranches will not be squash-merged at release time.