Merged
Conversation
krlawrence
requested changes
Jul 12, 2022
Contributor
krlawrence
left a comment
krlawrence
left a comment
There was a problem hiding this comment.
I need to finish reading but suggested a few upfront wording changes
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
joywa
reviewed
Jul 12, 2022
Contributor
joywa
left a comment
joywa
left a comment
There was a problem hiding this comment.
A great guide, easy to understand. Some suggestions for consistent formatting and improving customer experience of this notebook.
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Outdated
Show resolved
Hide resolved
src/graph_notebook/notebooks/06-Language-Tutorials/01-SPARQL/01-SPARQL-BASICS.ipynb
Show resolved
Hide resolved
Contributor
|
Worked with @charlesivie offline, latest draft looks good for merging. |
krlawrence
previously approved these changes
Jul 26, 2022
michaelnchin
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The first of some SPARQL tutorials to be included in the notebooks. This is the basics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.