Fix IPython config dir retrieval logic#687
Merged
michaelnchin merged 2 commits intoaws:mainfrom Aug 29, 2024
bauer-at-work:main
Merged
Fix IPython config dir retrieval logic#687michaelnchin merged 2 commits intoaws:mainfrom bauer-at-work:main
michaelnchin merged 2 commits intoaws:mainfrom
bauer-at-work:main
Conversation
Apply IPython's own logic to retrieve the location of the IPython configuration directory as detailed in the [docs](https://ipython.readthedocs.io/en/stable/development/config.html#configuration-file-location). This allows reuse of custom config dirs like ~/.config/ipython or any path specified via IPYTHONDIR environment variable.
michaelnchin
approved these changes
Aug 29, 2024
Member
michaelnchin
left a comment
michaelnchin
left a comment
There was a problem hiding this comment.
Thank you @bauer-at-work !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Apply IPython's own logic to retrieve the location of the IPython configuration directory as detailed in the docs. This allows reuse of custom config dirs like ~/.config/ipython or any path specified via IPYTHONDIR environment variable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.