Skip to content

Commit e8c7b12

Browse files
RomainMullermergify[bot]
RomainMuller
authored and
mergify[bot]
committed
chore: upgrade to @types/node 10.x (#894)
Actually upgrade the `node` engine support to 10.x tree, as has been declared in the `package.json` files for a month now. Additionally, standardized the `compilerOptions` in the `tsconfig.json` files that are *not* generated by `jsii`, in order to use `ES2018` standard library, enable `strict` mode (this includes `strictPropertyInitialization`, which was not enabled previously and required a few code changes in `jsii-pacmak` that were made ad-minima). The library clause of `tsconfig.json` files that are generated by `jsii` has not been changed yet. This means you need to use `node >= 10.x` in order to use `jsii`, but you cannot use it to build code that depend on APIs that are not yet available in `node 8`. This behavior will be updated in a second phase. Related: #794
1 parent 5d7824d commit e8c7b12

26 files changed

Lines changed: 270 additions & 642 deletions

File tree

‎.dependabot/config.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ update_configs:
1010
- match:
1111
# Don't suggest upgrading @types/node to versions >= 9
1212
dependency_name: '@types/node'
13-
version_requirement: '>= 9'
13+
version_requirement: '>= 11'
1414
- match:
1515
# Don't suggest upgrading decamelize to version >= 2
1616
dependency_name: decamelize

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"test": "lerna run test --stream"
1010
},
1111
"devDependencies": {
12-
"@types/node": "^8.10.55",
12+
"@types/node": "^10.14.22",
1313
"@typescript-eslint/eslint-plugin": "^2.4.0",
1414
"@typescript-eslint/parser": "^2.4.0",
1515
"eslint": "^6.5.1",

‎packages/codemaker/tsconfig.json‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
{
22
"compilerOptions": {
3-
"target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
3+
"target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
44
"module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
5-
"lib": ["es2016", "es2017.object", "es2017.string"], /* Specify library files to be included in the compilation: */
6-
"declaration": true, /* Generates corresponding '.d.ts' file. */
5+
"lib": ["es2018"], /* Specify library files to be included in the compilation: */
76
"strict": true, /* Enable all strict type-checking options. */
8-
"noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
9-
"strictNullChecks": true, /* Enable strict null checks. */
10-
"noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
117
"alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
8+
"declaration": true, /* Generates corresponding '.d.ts' file. */
9+
"inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
10+
"inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */
1211
"noUnusedLocals": true, /* Report errors on unused locals. */
1312
"noUnusedParameters": true, /* Report errors on unused parameters. */
1413
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
1514
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
16-
"inlineSourceMap": true,
17-
"inlineSources": true,
18-
"composite": true
15+
"resolveJsonModule": true, /* Include modules imported with .json extension. */
16+
"composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */
17+
"incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */
1918
}
2019
}

‎packages/jsii-diff/tsconfig.json‎

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,20 @@
11
{
22
"compilerOptions": {
3-
"target": "ES2017",
4-
"module": "commonjs",
5-
"lib": ["es2016", "es2017.object", "es2017.string"],
6-
"declaration": true,
7-
"strict": true,
8-
"noImplicitAny": true,
9-
"strictNullChecks": true,
10-
"noImplicitThis": true,
11-
"alwaysStrict": true,
12-
"strictPropertyInitialization": false,
13-
"noUnusedLocals": true,
14-
"noUnusedParameters": true,
15-
"noImplicitReturns": true,
16-
"noFallthroughCasesInSwitch": true,
17-
"inlineSourceMap": true,
18-
"inlineSources": true,
19-
"experimentalDecorators": true,
20-
"composite": true
3+
"target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
4+
"module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
5+
"lib": ["es2018"], /* Specify library files to be included in the compilation: */
6+
"strict": true, /* Enable all strict type-checking options. */
7+
"alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
8+
"declaration": true, /* Generates corresponding '.d.ts' file. */
9+
"inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
10+
"inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */
11+
"noUnusedLocals": true, /* Report errors on unused locals. */
12+
"noUnusedParameters": true, /* Report errors on unused parameters. */
13+
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
14+
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
15+
"resolveJsonModule": true, /* Include modules imported with .json extension. */
16+
"composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */
17+
"incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */
2118
},
2219
"include": [
2320
"**/*.ts"

‎packages/jsii-dotnet-analyzers/tsconfig.json‎

Lines changed: 15 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,19 @@
11
{
22
"compilerOptions": {
3-
/* Basic Options */
4-
"target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
5-
"module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
6-
"lib": ["es2016", "es2017.object", "es2017.string"], /* Specify library files to be included in the compilation: */
7-
// "allowJs": true, /* Allow javascript files to be compiled. */
8-
// "checkJs": true, /* Report errors in .js files. */
9-
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
10-
"declaration": true, /* Generates corresponding '.d.ts' file. */
11-
// "sourceMap": true, /* Generates corresponding '.map' file. */
12-
// "outFile": "./", /* Concatenate and emit output to single file. */
13-
// "outDir": "./", /* Redirect output structure to the directory. */
14-
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
15-
// "removeComments": true, /* Do not emit comments to output. */
16-
// "noEmit": true, /* Do not emit outputs. */
17-
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
18-
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
19-
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
20-
21-
/* Strict Type-Checking Options */
22-
"strict": true, /* Enable all strict type-checking options. */
23-
"noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
24-
"strictNullChecks": true, /* Enable strict null checks. */
25-
"noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
26-
"alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
27-
"strictPropertyInitialization": false, /* DO NOT Raise error on class attribute not initialized by constructor. */
28-
29-
/* Additional Checks */
30-
"noUnusedLocals": true, /* Report errors on unused locals. */
31-
"noUnusedParameters": true, /* Report errors on unused parameters. */
32-
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
33-
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
34-
35-
/* Module Resolution Options */
36-
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
37-
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
38-
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
39-
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
40-
// "typeRoots": [], /* List of folders to include type definitions from. */
41-
// "types": [], /* Type declaration files to be included in compilation. */
42-
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
43-
44-
/* Source Map Options */
45-
// "sourceRoot": "./", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
46-
// "mapRoot": "./", /* Specify the location where debugger should locate map files instead of generated locations. */
47-
// "inlineSourceMap": false, /* Emit a single file with source maps instead of having a separate file. */
48-
// "inlineSources": false, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
49-
50-
/* Experimental Options */
51-
"experimentalDecorators": true /* Enables experimental support for ES7 decorators. */
52-
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
3+
"target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
4+
"module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
5+
"lib": ["es2018"], /* Specify library files to be included in the compilation: */
6+
"strict": true, /* Enable all strict type-checking options. */
7+
"alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
8+
"declaration": true, /* Generates corresponding '.d.ts' file. */
9+
"inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
10+
"inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */
11+
"noUnusedLocals": true, /* Report errors on unused locals. */
12+
"noUnusedParameters": true, /* Report errors on unused parameters. */
13+
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
14+
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
15+
"resolveJsonModule": true, /* Include modules imported with .json extension. */
16+
"composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */
17+
"incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */
5318
}
5419
}

‎packages/jsii-dotnet-jsonmodel/tsconfig.json‎

Lines changed: 15 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,19 @@
11
{
22
"compilerOptions": {
3-
/* Basic Options */
4-
"target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
5-
"module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
6-
"lib": ["es2016", "es2017.object", "es2017.string"], /* Specify library files to be included in the compilation: */
7-
// "allowJs": true, /* Allow javascript files to be compiled. */
8-
// "checkJs": true, /* Report errors in .js files. */
9-
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
10-
"declaration": true, /* Generates corresponding '.d.ts' file. */
11-
// "sourceMap": true, /* Generates corresponding '.map' file. */
12-
// "outFile": "./", /* Concatenate and emit output to single file. */
13-
// "outDir": "./", /* Redirect output structure to the directory. */
14-
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
15-
// "removeComments": true, /* Do not emit comments to output. */
16-
// "noEmit": true, /* Do not emit outputs. */
17-
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
18-
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
19-
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
20-
21-
/* Strict Type-Checking Options */
22-
"strict": true, /* Enable all strict type-checking options. */
23-
"noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
24-
"strictNullChecks": true, /* Enable strict null checks. */
25-
"noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
26-
"alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
27-
"strictPropertyInitialization": false, /* DO NOT Raise error on class attribute not initialized by constructor. */
28-
29-
/* Additional Checks */
30-
"noUnusedLocals": true, /* Report errors on unused locals. */
31-
"noUnusedParameters": true, /* Report errors on unused parameters. */
32-
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
33-
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
34-
35-
/* Module Resolution Options */
36-
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
37-
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
38-
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
39-
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
40-
// "typeRoots": [], /* List of folders to include type definitions from. */
41-
// "types": [], /* Type declaration files to be included in compilation. */
42-
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
43-
44-
/* Source Map Options */
45-
// "sourceRoot": "./", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
46-
// "mapRoot": "./", /* Specify the location where debugger should locate map files instead of generated locations. */
47-
// "inlineSourceMap": false, /* Emit a single file with source maps instead of having a separate file. */
48-
// "inlineSources": false, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
49-
50-
/* Experimental Options */
51-
"experimentalDecorators": true /* Enables experimental support for ES7 decorators. */
52-
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
3+
"target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
4+
"module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
5+
"lib": ["es2018"], /* Specify library files to be included in the compilation: */
6+
"strict": true, /* Enable all strict type-checking options. */
7+
"alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
8+
"declaration": true, /* Generates corresponding '.d.ts' file. */
9+
"inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
10+
"inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */
11+
"noUnusedLocals": true, /* Report errors on unused locals. */
12+
"noUnusedParameters": true, /* Report errors on unused parameters. */
13+
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
14+
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
15+
"resolveJsonModule": true, /* Include modules imported with .json extension. */
16+
"composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */
17+
"incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */
5318
}
5419
}

0 commit comments

Comments
 (0)
⚡