chore: upgrade to @types/node 10.x#894
Conversation
Actually upgrade the `node` engine support to 10.x tree, as has been declared in the `package.json` files for a month now. Additionally, standardized the `compilerOptions` in the `tsconfig.json` files that are *not* generated by `jsii`, in order to use `ES2018` standard library, enable `strict` mode (this includes `strictPropertyInitialization`, which was not enabled previously and required a few code changes in `jsii-pacmak` that were made ad-minima). The library clause of `tsconfig.json` files that are generated by `jsii` has not been changed yet. This means you need to use `node >= 10.x` in order to use `jsii`, but you cannot use it to build code that depend on APIs that are not yet available in `node 8`. This behavior will be updated in a second phase. Related: #794
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
left a comment
nija-at
left a comment
There was a problem hiding this comment.
Have you run a sanity check against a few CDK modules to ensure that all of the JSII libraries are consumed and function correctly? Including libraries that consume jsii-reflect, and the like.
|
@nija-at so I have ran a full build of |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
3 participants
Actually upgrade the
nodeengine support to 10.x tree, as hasbeen declared in the
package.jsonfiles for a month now.Additionally, standardized the
compilerOptionsin thetsconfig.jsonfilesthat are not generated by
jsii, in order to useES2018standard library,enable
strictmode (this includesstrictPropertyInitialization, which was notenabled previously and required a few code changes in
jsii-pacmakthat weremade ad-minima).
The library clause of
tsconfig.jsonfiles that are generated byjsiihas notbeen changed yet. This means you need to use
node >= 10.xin order to usejsii, but you cannot use it to build code that depend on APIs that are not yetavailable in
node 8. This behavior will be updated in a second phase.Fixes #794
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.