fix(jsii-pacmack): default to target directory mode#363
Merged
Conversation
Always generate to `$root/dist/TARGET`, even when only generating one target. This behavior works better for selectively building targets in a larger build that expects certain naming conventions.
eladb
approved these changes
Feb 14, 2019
Contributor
eladb
left a comment
eladb
left a comment
There was a problem hiding this comment.
I am sure something will break but have no idea how to test
RomainMuller
added a commit
that referenced
this pull request
Feb 27, 2019
### Bug Fixes * **jsii-pacmack:** default to target directory mode ([#363](#363)) ([967d917](967d917)) * **java-runtime:** Bump version of Jackson because of CVEs ([#362](#362)) ([140aa4d](140aa4d)) * **jsii:** detect double interface member declarations ([#360](#360)) ([b2b2c89](b2b2c89)), closes [#340](#340)
RomainMuller
added a commit
that referenced
this pull request
Feb 27, 2019
### Bug Fixes * **jsii-pacmack:** default to target directory mode ([#363](#363)) ([967d917](967d917)) * **java-runtime:** Bump version of Jackson because of CVEs ([#362](#362)) ([140aa4d](140aa4d)) * **jsii:** detect double interface member declarations ([#360](#360)) ([b2b2c89](b2b2c89)), closes [#340](#340)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always generate to
$root/dist/TARGET, even when onlygenerating one target. This behavior works better
for selectively building targets in a larger build that
expects certain naming conventions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.