feat(kernel): Normalize empty structs to undefined#416
Merged
RomainMuller merged 2 commits intomasterfrom Apr 2, 2019
Merged
Conversation
Upon deserializing objects from a "native" front-end (Java, .NET, ...), the kernel now interprets an empty value for a struct type (aka data type) as `undefined`, since front-ends that perform keyword lifting such as Python will not be able to distinguish between "no argument passed" and "an empty argument passed". Fixes #411
eladb
reviewed
Apr 1, 2019
Contributor
eladb
left a comment
eladb
left a comment
There was a problem hiding this comment.
Should we add a conformance test for this as well?
eladb
approved these changes
Apr 1, 2019
Contributor
|
Shall we get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon deserializing objects from a "native" front-end (Java, .NET, ...),
the kernel now interprets an empty value for a struct type (aka data
type) as
undefined, since front-ends that perform keyword lifting suchas Python will not be able to distinguish between "no argument passed"
and "an empty argument passed".
Fixes #411
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.