Skip to content

chore: fix typo in error message - delcaration#4514

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
huntharo:delcaration
May 16, 2024
Merged

chore: fix typo in error message - delcaration#4514
mergify[bot] merged 1 commit intoaws:mainfrom
huntharo:delcaration

Conversation

@huntharo
Copy link
Copy Markdown
Contributor

Observed the error below: The implemented delcaration is here.

delcaration - I kept looking at this because it hurt my eyes until I finally realized it was a typo.

At the very least, this can be closed as won't fix so that at least there will be a record for the next person that searches for an issue or fix for it.

Observed Error Message

[2024-05-15T12:22:12.636] [ERROR] jsii/compiler - Type model errors prevented the JSII assembly from being created
src/myconstruct.ts:191:31 - error JSII5004: "cdkConstruct.MyConstruct#dynamoDBTable" changes the property type to "aws-cdk-lib.aws_dynamodb.Table" when implementing cdkConstruct.IMyConstruct. Change it to "aws-cdk-lib.aws_dynamodb.ITable"

191   public get dynamoDBTable(): dynamodb.Table | undefined {
                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~

  src/myconstruct.ts:174:28
    174   readonly dynamoDBTable?: dynamodb.ITable;
                                   ~~~~~~~~~~~~~~~
    The implemented delcaration is here.
👾 Task "build » compile" failed when executing "jsii --silence-warnings=reserved-word" (cwd: packages/cdk)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 15, 2024

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@huntharo huntharo changed the title Typo in error message - delcaration docs: Typo in error message - delcaration May 15, 2024
@mrgrain mrgrain changed the title docs: Typo in error message - delcaration chore: fix typo in error message - delcaration May 16, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 16, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify Bot added the pr/ready-to-merge This PR is ready to be merged. label May 16, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 16, 2024

Merging (with squash)...

@mergify mergify Bot merged commit 8e5927f into aws:main May 16, 2024
@mergify mergify Bot removed the pr/ready-to-merge This PR is ready to be merged. label May 16, 2024
@huntharo huntharo deleted the delcaration branch May 20, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants