Skip to content

fix(pacmak): Twine 5.1.0 not found#4554

Merged
mergify[bot] merged 1 commit intomainfrom
revert-4516-dependabot/pip/packages/jsii-pacmak/lib/targets/python/twine-approx-eq-5.1.0
Jun 26, 2024
Merged

fix(pacmak): Twine 5.1.0 not found#4554
mergify[bot] merged 1 commit intomainfrom
revert-4516-dependabot/pip/packages/jsii-pacmak/lib/targets/python/twine-approx-eq-5.1.0

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Jun 26, 2024

Twine 5.1.0 has been yanked (removed) due to the issue described in pypa/twine#1125

This PR reverts the requirements-dev.txt file used by jsii-pacmak back to twine~=5.0.0.

@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Jun 26, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 26, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify Bot added the pr/ready-to-merge This PR is ready to be merged. label Jun 26, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 26, 2024

Merging (with squash)...

@mergify mergify Bot merged commit b4cc08c into main Jun 26, 2024
@mergify mergify Bot deleted the revert-4516-dependabot/pip/packages/jsii-pacmak/lib/targets/python/twine-approx-eq-5.1.0 branch June 26, 2024 10:02
@mergify mergify Bot removed the pr/ready-to-merge This PR is ready to be merged. label Jun 26, 2024
mergify Bot pushed a commit to cdklabs/jsii-docgen that referenced this pull request Aug 26, 2024
The Windows compat build has been silently failing for a while due to [the twine issue](aws/jsii#4554) in jsii-pacmak.

Fixing the build, by upgrading the pacmak version.

Fixing the silent failure by adding a meta job that we can add a branch protection for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants