fix(jsii): Validate overriding does not affect optionality#549
Merged
Conversation
Optionality must remain unchancged when overriding methods and properties, such that types are pure with respects to Liskov's substitution.
eladb
suggested changes
Jun 24, 2019
Contributor
eladb
left a comment
eladb
left a comment
There was a problem hiding this comment.
Can we add a test that verifies that this is caught between base/derived and abstract-base/derived
eladb
approved these changes
Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optionality must remain unchancged when overriding methods and
properties, such that types are pure with respects to Liskov's
substitution.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.