New .NET Generator with new expected files#567
Merged
RomainMuller merged 20 commits intomasterfrom Aug 1, 2019
Merged
Conversation
…rator-rewrite-merge
RomainMuller
force-pushed
the
master
branch
3 times, most recently
from
1315be5 to
8552b7a
Compare
added 2 commits
July 22, 2019 16:28
Contributor
|
I am working on the merge from master + regen. |
added 5 commits
July 25, 2019 14:06
Contributor
|
The branch is now conflicting, I'll do a merge + conflict resolution + regen |
… missing full interface type
costleya
approved these changes
Aug 1, 2019
Contributor
costleya
left a comment
costleya
left a comment
There was a problem hiding this comment.
This is mostly the same code as before, and the changes made I am familiar with. Outputted test binaries work as expected. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Resubmitting because of a premature merge)
Needs at least this bugfix applied, and potentially more:
4926bfd
Hi,
This contains a new generator for .NET written in typescript with the new expected files
This also removes of the old generator codebase.
Fixes #463
Fixes #528
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.