fix(kernel): correctly serialize enum values#754
Merged
RomainMuller merged 3 commits intomasterfrom Aug 29, 2019
Merged
Conversation
When string-valued enums were serialized, an incorrect reference would be created if the label of the enum entry did not match it's string value; due to the lookup code being incorrect. Updated a string-valued enum and introduced new compliance tests to ensure such enum values are passed across correctly. Fixes #753
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When string-valued enums were serialized, an incorrect reference would
be created if the label of the enum entry did not match it's string
value; due to the lookup code being incorrect.
Updated a string-valued enum and introduced new compliance tests to
ensure such enum values are passed across correctly.
Fixes #753
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.