fix(pacmak): put package README into the right Python module#928
Merged
fix(pacmak): put package README into the right Python module#928
Conversation
The (translated) Python README used to be written to the `<module>._jsii` module, as opposed to the main module. Put it in the right module where people will actually look for it.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Nov 1, 2019
| @@ -1,3 +1,6 @@ | |||
| """ | |||
Contributor
There was a problem hiding this comment.
does it make sense to include an empty docstring or perhaps omit it if it's empty?
| heading will be used as the Sphinx topic name. Otherwise, the name of the module | ||
| (`jsii-calc`) will be used instead. | ||
|
|
||
| ## Code Samples |
RomainMuller
approved these changes
Nov 4, 2019
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
removed
the
pr/do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (translated) Python README used to be written to the
<module>._jsiimodule, as opposed to the main module.Put it in the right module where people will actually look for it.
Fixes #
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.