fix: avoid selecting subnets with insufficient available IP address#7310
fix: avoid selecting subnets with insufficient available IP address#7310Vacant2333 wants to merge 1 commit intoaws:mainfrom
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Vacant2333
force-pushed
the
feat-select-the-most-availalbe-ip-count-subnet
branch
from
22ed451 to
4348646
Compare
Vacant2333
changed the title
|
@jmdeal @jonathan-innis hi, can u help me review, this pr will resolve the issue #5234 |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Vacant2333
force-pushed
the
feat-select-the-most-availalbe-ip-count-subnet
branch
from
4348646 to
d120906
Compare
|
@jmdeal can u help me reveiw? thanks |
|
@rschalo I know you're incredibly busy, but this PR would be a game-changer for us. It addresses the persistent issue we've been struggling with in #5234, and getting it merged would genuinely make a world of difference for our team. We're counting on your expertise to give it the green light. Thank you so much for considering this 🙏 |
|
Hi All - there is not currently a unit test around this behavior. Could we add one where we assert a subnet is no longer considered if IP exhaustion is expected? From a quick look I think it'd be tested via targeting one zone in a test for InstanceProvider create and an with update to the mock EC2 provider that adds a subnet with 0 available IPs for the targeted zone but not sure how that affects other tests. |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
|
Hey can we have an update on this please? 🙏 @rschalo |
|
/assign |
|
Can we bring in #7549 to this PR? Related changes should be a part of the same PR. Can you please also address the errors flagged by the CI? |
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
Vacant2333
force-pushed
the
feat-select-the-most-availalbe-ip-count-subnet
branch
from
390c0d6 to
66d3323
Compare
Hello @saurav-agarwalla ! I’m inviting the author of #7549 to co-edit this PR with me. I’ve already addressed your comments and fixed the CI issues. Thank you for helping me move this PR forward! |
|
Closing this in favor of #7623 so that we can track the discussions in a single thread. |
4 participants
Fixes #5234
#2921
Description
its a feature that when launchInstance select the subnet which has the most available ip count.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.