Skip to content

feat: Support delayed registration for AWS KWOK#8145

Merged
jonathan-innis merged 1 commit intoaws:mainfrom
jonathan-innis:allow-delayed-registration
May 30, 2025
Merged

feat: Support delayed registration for AWS KWOK#8145
jonathan-innis merged 1 commit intoaws:mainfrom
jonathan-innis:allow-delayed-registration

Conversation

@jonathan-innis
Copy link
Copy Markdown
Contributor

Fixes #N/A

Description

Support 30s delayed registration for launching nodes with the AWS kwok cloudprovider to mock the instance startup time. Eventually, we may be able to extend this to have different launch times based on the instance types

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner May 29, 2025 18:49
@jonathan-innis jonathan-innis requested a review from tzneal May 29, 2025 18:49
@netlify
Copy link
Copy Markdown

netlify bot commented May 29, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 07ef9f0
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/6838f5824dae7500080cab8d

@jonathan-innis jonathan-innis force-pushed the allow-delayed-registration branch 3 times, most recently from b129eab to a83ac74 Compare May 29, 2025 18:55
@coveralls
Copy link
Copy Markdown

coveralls commented May 29, 2025

Pull Request Test Coverage Report for Build 15336037365

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.862%

Totals Coverage Status
Change from base Build 15333723213: 0.0%
Covered Lines: 6963
Relevant Lines: 10414

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the allow-delayed-registration branch from a83ac74 to 229c7e6 Compare May 29, 2025 21:11
@jonathan-innis jonathan-innis enabled auto-merge (squash) May 29, 2025 21:18
@jonathan-innis jonathan-innis force-pushed the allow-delayed-registration branch 4 times, most recently from 3f3d1e8 to fde70eb Compare May 29, 2025 21:42
rschalo
rschalo previously approved these changes May 29, 2025
Copy link
Copy Markdown
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jonathan-innis jonathan-innis force-pushed the allow-delayed-registration branch 3 times, most recently from 15085e5 to 16cb917 Compare May 29, 2025 23:30
Comment thread kwok/ec2/ec2.go
@jonathan-innis jonathan-innis force-pushed the allow-delayed-registration branch from 16cb917 to 07ef9f0 Compare May 30, 2025 00:02
Copy link
Copy Markdown
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit ffad5ba into aws:main May 30, 2025
18 checks passed
@jonathan-innis jonathan-innis deleted the allow-delayed-registration branch May 30, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants