Update example by passing a request object through#7562
Merged
beqqrry-aws merged 3 commits intoawsdocs:mainfrom Sep 10, 2025
Merged
Update example by passing a request object through#7562beqqrry-aws merged 3 commits intoawsdocs:mainfrom
beqqrry-aws merged 3 commits intoawsdocs:mainfrom
Conversation
rlhagerm
requested review from
a team and
tejasgn1
and removed request for
a team
rlhagerm
added
the
Task
tejasgn1
approved these changes
Sep 9, 2025
Contributor
tejasgn1
left a comment
tejasgn1
left a comment
There was a problem hiding this comment.
The changes look good to me. There were no build issues with S3 PutObjectAsync example code and the test for it also ran without any error.
beqqrry-aws
added
On Call Review complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates a C++ S3 PutObjectAsync example by creating a request object in the main method to ensure it exists through all async calls.
Fix for https://taskei.amazon.dev/tasks/V1888980758
This example is used only in the C++ Dev. guide, not in the Code Examples library.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.