Remove deprecated update_neuron_sdk.sh lifecycle script#1050
Open
tmchow wants to merge 1 commit intoawslabs:mainfrom
Open
Remove deprecated update_neuron_sdk.sh lifecycle script#1050tmchow wants to merge 1 commit intoawslabs:mainfrom
tmchow wants to merge 1 commit intoawslabs:mainfrom
Conversation
The Neuron SDK is preinstalled on HyperPod Slurm AMIs and updated via the UpdateClusterSoftware API. The update_neuron_sdk.sh script pinned to SDK 2.21.0 (current is 2.27.1+) and was already disabled by default. Removed: - utils/update_neuron_sdk.sh - enable_update_neuron_sdk config flag from config.py - Conditional execution block from lifecycle_script.py - Neuron prompt from automate-cluster-creation.sh Fixes awslabs#973
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the deprecated
update_neuron_sdk.shlifecycle script and all references to it. The script was pinned to Neuron SDK 2.21.0 (current is 2.27.1+) and was already disabled by default in config.Why
HyperPod Slurm AMIs ship with the Neuron SDK preinstalled, and the SDK is automatically updated via the
UpdateClusterSoftwareAPI. This script is unnecessary and its pinned versions were significantly outdated.Changes
utils/update_neuron_sdk.shenable_update_neuron_sdkconfig flag fromconfig.pylifecycle_script.pyautomate-cluster-creation.shwith a comment explaining that no configuration is neededTesting
The
enable_update_neuron_sdkflag wasFalseby default, so this script was not executing in standard deployments. Removing it has no effect on existing clusters.Fixes #973
This contribution was developed with AI assistance (Claude Code).