Skip to content

fix(bedrock): Grant delete vectors permission to knowledge base execution role#1306

Open
gazoakley wants to merge 1 commit into
awslabs:mainfrom
gazoakley:bug/fix-kb-execution-role-s3-vectors-delete
Open

fix(bedrock): Grant delete vectors permission to knowledge base execution role#1306
gazoakley wants to merge 1 commit into
awslabs:mainfrom
gazoakley:bug/fix-kb-execution-role-s3-vectors-delete

Conversation

@gazoakley

Copy link
Copy Markdown

Fixes #1305


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko

krokoko commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Thanks @gazoakley , I think the fix looks good, have you tested it already to confirm ? If yes, we can make the PR ready and ship it.

@gazoakley gazoakley force-pushed the bug/fix-kb-execution-role-s3-vectors-delete branch from aa3ca73 to 39d9931 Compare April 29, 2026 09:58
@gazoakley gazoakley changed the title fix(bedrock): Grant delete vectors permission to KB execution role fix(bedrock): Grant delete vectors permission to knowledge base execution role Apr 29, 2026
@gazoakley gazoakley force-pushed the bug/fix-kb-execution-role-s3-vectors-delete branch from 39d9931 to d0b73a6 Compare April 29, 2026 10:45
@krokoko

krokoko commented May 5, 2026

Copy link
Copy Markdown
Collaborator

hi @gazoakley , just checking if the PR is ready for review ? Thanks !

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (b4af66a) to head (ce6a183).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1306    +/-   ##
========================================
  Coverage   95.31%   95.31%            
========================================
  Files          87       87            
  Lines       26551    26552     +1     
  Branches      473      777   +304     
========================================
+ Hits        25308    25309     +1     
  Misses       1243     1243            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions Bot added the stale label Jun 17, 2026
@gazoakley

Copy link
Copy Markdown
Author

hi @gazoakley , just checking if the PR is ready for review ? Thanks !

Hi @krokoko - in theory it works, but I haven't been able to get npm link to work in such as a way to test fully. Given the unit test passes I think it's likely to work when built properly. Are you OK to push this anyway?

@gazoakley gazoakley force-pushed the bug/fix-kb-execution-role-s3-vectors-delete branch from e193e2b to fe7636e Compare June 17, 2026 07:45
@gazoakley gazoakley marked this pull request as ready for review June 17, 2026 08:57
@gazoakley gazoakley requested a review from a team as a code owner June 17, 2026 08:57
@github-actions github-actions Bot removed the stale label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(bedrock): Unable to update S3 Vector knowledge bases

3 participants