feat(custom-resources): remove Docker build dependency from build phase#1340
Merged
Merged
Conversation
nizar-lahlali
requested review from
ClintEastman02,
Kalindi-Dev,
XinyuQu,
dineshSajwan,
isadeks,
krokoko and
scottschreckengaust
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
========================================
Coverage 95.31% 95.32%
========================================
Files 87 87
Lines 26551 26578 +27
Branches 777 479 -298
========================================
+ Hits 25308 25335 +27
Misses 1243 1243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nizar-lahlali
force-pushed
the
feature/remove-docker-build-dependency-567
branch
3 times, most recently
from
920553e to
6016335
Compare
Replace lambda.Code.fromDockerBuild() with lambda.Code.fromAsset() using local bundling (pip/poetry) with Docker fallback. This removes the hard Docker requirement at CDK synth time for environments where Python tooling is available locally. Fixes #567
nizar-lahlali
force-pushed
the
feature/remove-docker-build-dependency-567
branch
from
6016335 to
9f08734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #567
Replaces
lambda.Code.fromDockerBuild()withlambda.Code.fromAsset()using local bundling with Docker fallback in the sharedbuildCustomResourceProviderhelper.Changes
pip/poetryfirst (no Docker needed if Python tooling is available)user: 'root'to Docker bundling to fix permission issues with CDK's default user mappingAffected constructs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.