Remove target_os 'bitrig' in fuser which is unsupported by Rust#1107
Closed
dannycjones wants to merge 1 commit intoawslabs:fuser/forkfrom
Closed
Remove target_os 'bitrig' in fuser which is unsupported by Rust#1107dannycjones wants to merge 1 commit intoawslabs:fuser/forkfrom
dannycjones wants to merge 1 commit intoawslabs:fuser/forkfrom
Conversation
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
changed the title
Contributor
Author
|
This change was contributed upstream. Let's pick it up next time we update the fork. cberner/fuser@f69c838 |
Contributor
Author
|
Actually, let's just close this and rebase from the fork soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Our fuser fork emits a lot of warnings during builds, impacting our pull requests. This change addresses the use of undeclared target operating systems.
Bitrig is no longer developed and most changes were contributed back to its upstream OpenBSD. Bitrig support was removed from Rust in 2019 (rust-lang/rust#60775). This change removes the conditions from Fuser, who's MSRV is 1.74.
This change is a good candidate to be contributed to upstream (cberner/fuser#312). Once contributed, this commit can be removed.
Does this change impact existing behavior?
bitrigwill no longer be a supported operating system for fuser (though its unlikely it worked, given MSRV of 1.74).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).