Support default config fallback#1
Merged
DenisIzmaylov merged 2 commits intoaxept:masterfrom Apr 22, 2017
lttb:feature/support-default-config-fallback
Merged
Support default config fallback#1DenisIzmaylov merged 2 commits intoaxept:masterfrom lttb:feature/support-default-config-fallback
DenisIzmaylov merged 2 commits intoaxept:masterfrom
lttb:feature/support-default-config-fallback
Conversation
Contributor
|
Huge thanks Artur! Very appreciate it. Could you please apply some little updates? |
DenisIzmaylov
requested changes
Apr 22, 2017
| @@ -0,0 +1,34 @@ | |||
| import { asyncParser } from '../../src' | |||
|
|
|||
| const css = ` | |||
Contributor
There was a problem hiding this comment.
Could you please name it to rawCSS?
| } | ||
| ` | ||
|
|
||
| const objectCss = { |
Contributor
There was a problem hiding this comment.
Could you please name it as expectedJSS?
Contributor
|
You're cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's make postcss config optional - it would be easier start to use
prejssin first steps.@DenisIzmaylov